Skip to content

Resolve "Button for adding a rotation"

What does this MR do?

A tiny MVC for #262864 (closed) where we add the GlCard wrapper and GlButton for the add a rotation modal which is being handled in a separate MR here: !48553 (merged). These will be hooked up together once the target branches are merged and complete.

🇺🇦 This feature sits behind behind the feature flag oncall_schedules_mvc and the minimal license is GitLab Premium 👀

rails c
Feature.enable(:oncall_schedules_mvc)

Design

https://www.figma.com/file/gZF7Vvj1mmZGZFkV9wXTpY/Design-discovery-on-call-scheduling-gitlab-com-and-25995?node-id=374%3A720

Screenshots (strongly suggested)

Screenshot_2020-12-02_at_10.51.39

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #262864 (closed)

Edited by David O'Regan

Merge request reports