Skip to content

Add rotation modal

David O'Regan requested to merge 262857-add-a-rotation-modal into master

What does this MR do?

The first of four merges to complete: #262857 (closed)

frontend Merges(DoD) You are
Rotation modal without token colors 🤘
GitLab UI token color support gitlab-ui!1873 (merged)
Token colors added
GraphQL mutation updated to backend model

Please read before reviewing this merge:

  • This merge adds a Red button to the empty state screen ONLY for UX testing purposes, this button will be replaced with the correct button once the initial work for the schedule work is complete. See #262864 (closed)
  • This merge requires a supporting merge from gitlab/ui to allow for colors to be added to user tokens. At the moment the text is white for the tokens as per the design: https://design.gitlab.com/data-visualization/color#categorical-data, this looks wrong now but will be solved when we get to merge 3.
  • The 24 hour starts on clock is generated on the frontend until there is a choice made about how to handle it via the backend.
  • The error state happens inside the modal as per the schedule modal for design consistency.
  • This merge adds a shared query for searching for users through GraphQL

Screenshots (strongly suggested)

Screenshot_2020-11-25_at_14.57.22

Screenshot_2020-11-25_at_16.56.33

Screenshot_2020-11-25_at_16.56.47

Screenshot_2020-11-25_at_16.56.52

Screenshot_2020-11-25_at_16.57.01

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #262857 (closed)

Edited by David O'Regan

Merge request reports

Loading