Skip to content
Snippets Groups Projects

Resolve Members page 500 error after Invitation sent via API

What does this MR do?

Fixes #290006 (closed)

Handles the case when a Member has been both Invited and also Requested access to the Project.

The error was occurring when the shared/members/_member.html.haml view tried to display a message including the user name to revoke a Member that had not created a User account yet, but had been sent an invite_token.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #290006 (closed)

Edited by Jackie Fraser

Merge request reports

Merged results pipeline #226324603 passed with warnings

Merged results pipeline passed with warnings for f7588a11

Test coverage 69.59% (12.24%) from 3 jobs
Approval is optional

Merged by Jan ProvaznikJan Provaznik 4 years ago (Dec 8, 2020 7:35am UTC)

Merge details

Pipeline #226642506 canceled

Pipeline canceled for 27da16c9 on master

5 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading