Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 34,968
    • Issues 34,968
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,266
    • Merge Requests 1,266
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !48805

Open
Opened Nov 30, 2020 by Michael Lunøe@mlunoe🔴Developer0 of 13 tasks completed0/13 tasks
  • Report abuse
Report abuse

Draft: Refactor(profile preferences): migrate behavior to Vue

  • Overview 2
  • Commits 2
  • Pipelines 7
  • Changes 22

What does this MR do?

This MR refactors the behavior and localization settings of the profile/preferences page from HAML to Vue as a stepping stone to achieving these goals:

  • #259621
  • #250846
  • #21320
  • gitlab-com/www-gitlab-com#8765

Related history:

  • MR 1: !46138 (merged)
  • MR 2: !49032
  • MR 3: This one

The final piece will be to move the form to submit in Vue so that we can remove this file: profiles/preferences/update.js.erb

Screenshots (strongly suggested)

Before: After:
Screen_Shot_2020-11-30_at_17.23.57 Screen_Shot_2020-11-30_at_17.24.51

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #250846

Edited Dec 02, 2020 by Michael Lunøe
Assignee
Assign to
Reviewer
Request review from
13.9
Milestone
13.9
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!48805
Source branch: 250846-mlunoe-migrate-group-overview-selector-from-haml