Remove last remaining inline JavaScript
eval
of Views
Priority 1: We need to clean those as soon as possible as they might oppose a risk.
JS views that are eval
ed by jQuery using script
tags (find app/views -name ".js."):
-
app/views/projects/group_links/update.js.haml -> #250655 (closed) (removed in !42745 (merged)) -
app/views/projects/remove_fork.js.haml => #250697 (closed) (Seems to be not in use anymore)Removed with #345124 (closed) -
app/views/projects/transfer.js.haml => #250697 (closed) (Seems to be not in use anymore)!72361 (merged). -
app/views/projects/tags/destroy.js.haml => #250834 (closed) (in use, fairly easy to move) -
app/views/projects/refs/logs_tree.js.haml => Deleted already -
app/views/projects/milestones/update.js.haml => #250835 (closed) (We should be able to simply delete) -
app/views/projects/update.js.haml => #250837 (closed) (Might be more complex to port) -
app/views/admin/labels/destroy.js.haml => #250839 (closed) -
app/views/admin/runners/update.js.haml => Deleted already -
app/views/shared/snippets/show.js.haml => gitlab-org/gitlab#250840 (Should be easily moveable) -
app/views/shared/members/update.js.haml => #250843 (closed) (Removed in !44048 (merged)) -
app/views/groups/labels/destroy.js.haml => #250845 (closed) (deleted in !42643 (merged)) -
app/views/profiles/preferences/update.js.erb => #250846 (closed) (more complex) => Currently being worked on by @mlunoe -
app/views/import/bitbucket/deploy_key.js.haml => #250847 (closed) (should be easy) -
app/views/help/shortcuts.js.haml => #250848 (closed) (should be easy) -
ee/app/views/users/available_group_templates.js.haml #353339 (closed) -
ee/app/views/users/available_project_templates.js.haml #353340 (closed)
Priority Low: Disabled Linters
Different Linter Warnings or disabled Linters that would be nice to fix but no imminent risk.
There are still a few places where we disable the InlineJavaScript
haml linter that was introduced in
gitlab-ce!9742 (git grep 'InlineJavaScript'
):
-
app/views/layouts/_google_analytics.html.haml (TZ: Is a javascript_tag
by now) -
app/views/layouts/_init_auto_complete.html.haml (TZ: Is a javascript_tag
by now) -
app/views/layouts/_piwik.html.haml (TZ: Is a javascript_tag
by now) -
app/views/layouts/group.html.haml (TZ: Is a javascript_tag
by now) -
app/views/layouts/project.html.haml (TZ: Is a javascript_tag
by now) -
app/views/layouts/snippets.html.haml (TZ: Is a javascript_tag
by now) -
app/views/projects/merge_requests/show.html.haml (TZ: JSON serialization uses html_safe -
app/views/u2f/_register.html.haml (TZ: Doesn't exist anymore) -
app/views/u2f/_authenticate.html.haml (TZ: Doesn't exist anymore) -
app/views/shared/notes/_notes_with_form.html.haml (TZ: !42574 (merged)) -
app/views/shared/issuable/_sidebar.html.haml (TZ: !42574 (merged)) -
app/views/shared/boards/_show.html.haml (TZ: !42574 (merged)) -
app/views/projects/tags/new.html.haml (TZ: !42574 (merged)) -
app/views/projects/branches/new.html.haml (TZ: !42574 (merged)) -
app/views/projects/edit.html.haml (TZ: No inline script anymore) -
app/views/projects/graphs/charts.html.haml (TZ: No inline script anymore) -
app/views/projects/issues/show.html.haml (EK: No inline script anymore !42667 (merged)) -
app/views/projects/pipelines/charts/_pipeline_times.haml -
app/views/projects/pipelines/charts/_pipelines.haml -
app/views/projects/pipelines/new.html.haml -
ee/app/views/groups/analytics/show.html.haml (TZ: Doesn't exist anymore) -
ee/app/views/profiles/slacks/edit.html.haml -
app/views/projects/blob/_header.html.haml (TZ: No inline JS anymore)
Previous issues: gitlab-ce#19866 gitlab-ce#34903
cc: @ClemMakesApps @winh
Edited by Mark Florian