Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,030
    • Issues 35,030
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,257
    • Merge Requests 1,257
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Security & Compliance
    • Security & Compliance
    • Dependency List
    • License Compliance
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !48670

Merged
Opened Nov 27, 2020 by Dheeraj Joshi@djadmin💡Developer1 of 14 tasks completed1/14 tasks

Refactor DAST Profiles List components

  • Overview 14
  • Commits 9
  • Pipelines 6
  • Changes 10

Implements #285454 (closed)

What does this MR do?

This MR breaks down DAST Profiles List components to make it a composable component which should keep site profile specific and a scanner profile specific logics separately.

  • It keeps the common feature likes loading, editing & deleting profiles intact
  • It keeps the common fields like profile names to be rendered same for all the profiles by default
  • It allows writing custom rendering for a profile specific fields using scoped slots
    • Using this, one can override common fields like profiles names too, which would be useful for future feature like #276484 (closed) (saved scans)

Before

graph LR
  A[DastProfiles] -->|Site, Scanner Profiles| B[DastProfilesList]
	

After

  graph LR
   DastProfiles --> DastSiteProfilesList & DastScannerProfilesList --> DastProfilesList

TODO

  • Add more specs related to slots / scoped slots

Screenshots (strongly suggested)

No visual changes

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited Nov 30, 2020 by Dheeraj Joshi
Assignee
Assign to
Reviewer
Request review from
13.7
Milestone
13.7 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!48670
Source branch: djadmin-dast-profiles-refactor

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.