Refactor Dast Profiles components
The following discussion from !48124 (merged) should be addressed:
-
@pgascouvaillancourt started a discussion: note: as discussed earlier, this implies that we're sharing some DAST sites-specific logic with DAST scanners as the
DastProfilesList
is used for both scanner types. This should be fine for now, but we should definitely refactor this in a follow-up to separate concerns a bit better. The idea we've discussed earlier was to break theDastProfilesList
component down into more composable components where we would have a site-specific and a scanner-specific wrappers, similar to what we've done for the on-demand DAST scans profiles selector (ee/app/assets/javascripts/on_demand_scans/components/profile_selector/
).
Implementation Plan
-
Create DastScannerProfilesList
andDastSiteProfilesList
components -
Make DastSiteProfilesList
a composable component -
Move site specific logic from DastProfilesList
toDastSiteProfilesList
-
Update specs
Edited by Dheeraj Joshi