Introduce exclusive lease for pages deployments
What does this MR do?
This is extracted from !47639 (diffs)
Currently, we don't need an exclusive lease when we deploy pages because we use mv
which is atomic.
But we'll need it later when we are zipping pages directory to avoid the situation when it's been moved while we're zipping it.
The implementation is mostly copied from https://gitlab.com/gitlab-org/gitlab/-/blob/fdaf37c62ae38f9ea39f4f4b64fb9f02b2e9cea8/app/uploaders/object_storage.rb#L452
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #282464 (closed)
Edited by Kamil Trzciński