Remove ci_variable_expansion_in_rules_changes feature flag
What does this MR do?
Related to #267192 (closed)
Removes ci_variable_expansion_in_rules_changes
feature flag. The changelog entry was added in !47783 (merged) when we defaulted the flag to true.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added backend documentation labels
2 Messages This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 48329 "Remove ci_variable_expansion_in_rules_changes feature flag"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 48329 "Remove ci_variable_expansion_in_rules_changes feature flag"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Documentation review
The following files require a review from a technical writer:
doc/ci/yaml/README.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Dmitry Gruzd ( @dgruzd
) (UTC+3, 1 hour ahead of@mbobin
)Sean McGivern ( @smcgivern
) (UTC+0, 2 hours behind@mbobin
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖changed milestone to %13.7
added CI rules Category:Continuous Integration devopsverify feature flag grouppipeline authoring sectionops typefeature + 1 deleted label
- Resolved by Marcel Amirault
@marcel.amirault, @dgruzd assigning this to you for documentation and backend reviews.
assigned to @dgruzd and @marcel.amirault
assigned to @smcgivern and unassigned @dgruzd
mentioned in commit 6fcec4f2
mentioned in issue gitlab-com/gl-infra/scalability#672
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added Technical Writing docsfeature labels
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-com/www-gitlab-com#6765 (closed)
added Category:Pipeline Composition label