Exclude periods from job log links
requested to merge 284835-job-log-links-404-when-the-url-is-immediately-followed-by-a-period into master
What does this MR do?
Exclude periods (.) from job log links. Related to #284835 (closed)
ci_job_line_links. Rollout issue at #281727 (closed)
URLs in logs may appears in sentences, and as such may have "dangling" periods which are not part of the URL.
This change extends the regex to exclude certain ending characters.
Screenshots (strongly suggested)
URLs followed by periods are correct.
| before | after |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon