[Feature flag] Rollout of `ci_job_line_links`
What
Remove the :ci_job_line_links
feature flag and enable clickable URL links in Jobs for all users. Feature issue: #18324 (closed)
Owners
- Team: ~"group::continuous integration"
- Most appropriate slack channel to reach out to:
#s_verify
or#s_verify_fe
- Best individual to reach out to: @mrincon
Expectations
What are we expecting to happen?
Viewing jobs of logs allows users to click on links.
What might happen if this goes wrong?-
- Sections of the logs dissapeared as we tried to parse
<
>
as html when using linkfyjs #270078 (comment 432967215) and !45690 (merged) - Blob with clickable links was reverted due to contents being parsed twice !19887 (diffs)
- Complex regex that looks for URLs can be abused and consume memory #18324 (comment 445721771)
What can we monitor to detect problems with this?
Beta groups/projects
If applicable, any groups/projects that are happy to have this feature turned on early. Some organizations may wish to test big changes they are interested in with a small subset of users ahead of time for example.
mrincon/my-ci-project
-
gitlab-org/gitlab
project
Roll Out Steps
-
Enable on staging ( /chatops run feature set feature_name true --staging
) -
Test on staging -
Ensure that documentation has been updated -
Enable on GitLab.com for individual groups/projects listed above and verify behaviour ( /chatops run feature set --project=gitlab-org/gitlab feature_name true
) -
Coordinate a time to enable the flag with the SRE oncall and release managers - In
#production
by pinging@sre-oncall
- In
#g_delivery
by pinging@release-managers
- In
-
Announce on the issue an estimated time this will be enabled on GitLab.com -
Enable on GitLab.com by running chatops command in #production
(/chatops run feature set feature_name true
) -
Cross post chatops Slack command to #support_gitlab-com
(more guidance when this is necessary in the dev docs) and in your team channel -
Announce on the issue that the flag has been enabled -
Remove feature flag and add changelog entry - The changelog entry should be as follows:
---
title: Make URL links in job logs clickable
merge_request: XXXX
author: Łukasz Groszkowski @falxcerebri
type: added
-
After the flag removal is deployed, clean up the feature flag by running chatops command in #production
channel
Rollback Steps
-
This feature can be disabled by running the following Chatops command:
/chatops run feature set --project=gitlab-org/gitlab feature_name false
Edited by Miguel Rincon