Skip to content
Snippets Groups Projects

Resolve "Mentioning users is now very slow"

Merged Ezekiel Kigbo requested to merge 285442-mentioning-users-is-now-very-slow into master

What does this MR do?

!47387 (merged) introduced a busy indicator next to the user name in multiple places, the change to the autocomplete causes performance issues.

This MR always passes nil for the availability field in the app/services/concerns/users/participable_service.rb. This means we will not display the busy status in the user autocomplete.

Screenshots (strongly suggested)

Before After
Screen_Shot_2020-11-16_at_9.52.15_pm Screen_Shot_2020-11-20_at_3.22.14_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #285442 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading