Resolve "Mentioning users is now very slow"
What does this MR do?
!47387 (merged) introduced a busy
indicator next to the user name in multiple places, the change to the autocomplete causes performance issues.
This MR always passes nil
for the availability
field in the app/services/concerns/users/participable_service.rb
. This means we will not display the busy
status in the user autocomplete.
Screenshots (strongly suggested)
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #285442 (closed)
Merge request reports
Activity
added bugperformance severity2 typebug labels
assigned to @ekigbo
added 1 commit
- 6c27e9c5 - Disable showing user availability in autocomplete
1 Warning ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message 📖 CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 48217 "Resolve "Mentioning users is now very slow""
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 48217 "Resolve "Mentioning users is now very slow""
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Dave Pisek ( @dpisek
) (UTC+11, same timezone as@ekigbo
)Kushal Pandya ( @kushalpandya
) (UTC+5.5, 5.5 hours behind@ekigbo
)backend Valery Sizov ( @vsizov
) (UTC+1, 10 hours behind@ekigbo
)Stan Hu ( @stanhu
) (UTC-8, 19 hours behind@ekigbo
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖changed milestone to %13.6
added groupoptimize label
Hey @ahegyi would you be free to review this change? Should we also ~"Pick into 13.6" ?
/cc @engwan @tkuah @rspeicher
mentioned in issue #285442 (closed)
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a50c7f1d and 6c27e9c5
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.16 MB 3.16 MB - 0.0 % mainChunk 1.95 MB 1.95 MB - 0.0 %
Note: We do not have exact data for a50c7f1d. So we have used data from: 63565a6e.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 Danger- Resolved by Ash McKenzie
Failing spec looks to be on master https://gitlab.com/gitlab-org/gitlab/-/jobs/862297348
assigned to @ashmckenzie
changed milestone to %13.7
So the
rspec unit pg11 17/20
failure is unrelated and being investigated at #285449 (closed). I feel this is safe to merge.