Skip to content

Global Search - Searchable Dropdown

Zack Cuddy requested to merge 262060_03-searchable-dropdown into master

What does this MR do?

This is work broken off a larger MR here: !45711 (merged)

When implementing the above linked MR I found a significant case of duplicated and overly complex code. This change creates a generic component SearchableDropdown that will be used by the Group and Project filter on Global Search.

The Group filter was previously implemented here: !44833 (merged)

This will allow us to not only remove a large set of duplicated code, but also allow us to keep these filters aligned in style to avoid issues like: #285229

Screenshots (strongly suggested)

Note no visible change should be found

Before After
Any Any_-_Before Any_-_After
Selected Group Selected_-_Before Selected_-_After
Searched Grouip Search_-_Before Search_-_After

GIF

Kapture_2020-11-19_at_15.03.34

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports