Skip to content

Global Search - Group Filter

Zack Cuddy requested to merge 262060_01-group-filter-vue into master

What does this MR do?

Part 1 of 2 for #262060 (closed)
Closes #268389 (closed)

This change replaces the deprecated jQuery Dropdown for the Group Filter on Global Search. It replaces the deprecated module with a Vue component using GlDropdown from GitLab UI.

To do so we simply moved the API calls and data tracking into the Vuex store and hooked it into a Vue component.

There is still some leftover usage of the Deprecated jQuery Dropdown here for the Project Filter. However, this change already has some line count to it so we will tackle that in a separate MR.

Screenshots

before after
Empty Query B-Empty_State Empty_State
With Group B-With_Grouip With_Group
Open Group Dropdown B-Open_State Open_State
Project dropdown respects group B-Project_Filter_by_Group Project_Filter_by_Group
Clear Button B-Clear_Button Clear_Button
Loading State B-Loading_State Loading_State

GIF

Functionality showcase Kapture_2020-10-22_at_13.45.54

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports