RUN AS-IF-FOSS Move deploy boards backend to core
What does this MR do?
Part one of moving deploy boards to core:
- Move EE model components into their core equivalent
- Move EE
lib/
concepts to core
Deploy boards as a feature are unchanged (still EE-only).
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Related to #212320 (closed)
Merge request reports
Activity
changed milestone to %13.7
added backend label
1 Warning This merge request is quite big (more than 1352 lines changed), please consider splitting it into multiple merge requests. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, run the following:
bin/changelog -m 47979 "RUN AS-IF-FOSS Move deploy boards backend to core"
If you want to create a changelog entry for GitLab EE, run the following instead:
bin/changelog --ee -m 47979 "RUN AS-IF-FOSS Move deploy boards backend to core"
If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Alex Buijs ( @alexbuijs
) (UTC+1, 10 hours behind@tigerwnz
)Jan Provaznik ( @jprovaznik
) (UTC+1, 10 hours behind@tigerwnz
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger Edited by 🤖 GitLab Bot 🤖added 785 commits
-
d0ba9f41...4ed028e8 - 782 commits from branch
master
- 17fe1bdd - Move plain classes to core
- 798cc6c5 - Move Kubernetes::Ingress to core
- af532a9a - Move deploy board model methods to core
Toggle commit list-
d0ba9f41...4ed028e8 - 782 commits from branch
added 206 commits
-
af532a9a...d708c675 - 203 commits from branch
master
- 4e15ad83 - Move plain classes to core
- 83533711 - Move Kubernetes::Ingress to core
- 362aca45 - Move deploy board model methods to core
Toggle commit list-
af532a9a...d708c675 - 203 commits from branch
@Alexand can you please give this an initial review? The diff looks a bit scary, but the vast majority of it is copy/pasted from EE files that are being removed. Thanks!
- Resolved by João Alexandre Cunha
I wonder what's gonna be the impact to our Redis DB once this feature gets moved to core. If we have many deploys on core, there could be a considerable increase in data cached.
Besides, we're broadening the possibility of finding some big deployments around. It might be interesting to keep an eye on
ExceededReactiveCacheLimit
error on Sentry. Nobody on GitLab.com EE has been reaching the limit. But it might change once opened to every project.Edited by João Alexandre Cunha
- Resolved by João Alexandre Cunha
Since this
canary_weight
feature was recently implemented by the Progressive Delivery team, is there anything that needs to be communicated?Sorry if I spam this message many times, my internet is failing and I'm retrying.
Edited by João Alexandre Cunha
- Resolved by Jan Provaznik
Thanks, @tigerwnz . Looks great!
Two non-blocking comments above. Maybe just double-check the
canary_weight
comment and move forward with the next reviewer.