WIP: Avoid using ||= to setup default for settings
What does this MR do?
Avoid using ||= to setup default for settings
This tries to update ||=
and setting = value if setting.nil?
to
set_default
. This also tries to make settings using a more
consistent way to setup values.
Are there points in the code the reviewer needs to double check?
I manually updated the first part and use regular expression to replace the rest. I hope all settings should remain the same.
We also need to port this to CE.
Why was this MR needed?
This is a proof of concept for https://gitlab.com/gitlab-org/gitlab-ce/issues/43264#note_61236125 avoiding https://gitlab.com/gitlab-org/gitlab-ee/issues/4915
Does this MR meet the acceptance criteria?
-
Tests added for this feature/bug - Review
-
Has been reviewed by Backend
-
-
Port to CE -
End-to-end tests pass ( package-qa
manual pipeline job)
What are the relevant issue numbers?
Edited by Lin Jen-Shin