Background upload option is not effective
With %10.5 we merged a significant refactor of Object Storage uploading code: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3867.
However, in a number of places we changed:
Settings.artifacts['object_store']['enabled'] = false if Settings.artifacts['object_store']['enabled'].nil?
Settings.artifacts['object_store']['remote_directory'] ||= nil
Settings.artifacts['object_store']['background_upload'] = true if Settings.artifacts['object_store']['background_upload'].nil?
Settings.lfs['object_store']['enabled'] = false if Settings.lfs['object_store']['enabled'].nil?
Settings.lfs['object_store']['remote_directory'] ||= nil
Settings.lfs['object_store']['background_upload'] = true if Settings.lfs['object_store']['background_upload'].nil?
TO:
Settings.artifacts['object_store']['enabled'] ||= false
Settings.artifacts['object_store']['remote_directory'] ||= nil
Settings.artifacts['object_store']['background_upload'] ||= true
Settings.lfs['object_store']['enabled'] ||= false
Settings.lfs['object_store']['remote_directory'] ||= nil
Settings.lfs['object_store']['background_upload'] ||= true
Settings.uploads['object_store']['enabled'] ||= false
Settings.uploads['object_store']['remote_directory'] ||= 'uploads'
Settings.uploads['object_store']['background_upload'] ||= true
Due to the way how we evaluate the values ||=
the false
setting provider by user in gitlab.yml
is not respected.
Thus, currently, all types uploads are uploaded to OS, and we have no way to disable it.
To mitigate that one of this has to be taken:
- the above code has to be patched to the previous form,
- disable background uploads
object_storage:*
,
Edited by Kamil Trzciński (Back 2025-01-01)