Skip to content

Remove un-used endpoint for embeddable Insights

Dan Jensen requested to merge 213924-remove-unused-embeddable-insights-code into master

What does this MR do?

This reverts !35535 (merged) (and some of !35963 (merged)) as suggested by @jeremy in gitlab-com/Product#1711 (comment 445286171).

A few months ago there was interest in enhancing the Insights feature to allow for these custom charts to be embedded in other contexts. As a first step toward that, an endpoint was introduced for these embeddable charts. However, it has been decided we have higher-priority features to pursue. So this removes that endpoint code, although we intend to pursue embeddable charts in the future so we will likely restore some or all of this code.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #213924 (closed)

Edited by Dan Jensen

Merge request reports