Skip to content
Snippets Groups Projects

Make schema breadcrumb urls absolute

All threads resolved!

What does this MR do?

In !46991 (merged) we include the logic to create the schema markup for breadcrumbs. For that we use the same info we use to build the regular HTML breadcrumb, including the link. These links are usually relative ones.

Although it's not totally certain, it seems tools that check schema markup, like the Google one, indicates that the url is invalid because it's relative.

In this MR we ensure to convert all relative links to absolute ones when creating the schema markup for the breadcrumb.

Does this MR meet the acceptance criteria?

Conformity

Related to #281378 (closed)

Edited by Francisco Javier López

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Vijay Hawoldar
  • Vijay Hawoldar approved this merge request

    approved this merge request

  • unassigned @vij

  • Francisco Javier López resolved all threads

    resolved all threads

  • added 1 commit

    • 89d3c28b - Make schema breadcrumb urls absolute

    Compare with previous version

  • added 220 commits

    Compare with previous version

  • Sean McGivern approved this merge request

    approved this merge request

  • Sean McGivern resolved all threads

    resolved all threads

  • Sean McGivern enabled an automatic merge when the pipeline for 5c0d3113 succeeds

    enabled an automatic merge when the pipeline for 5c0d3113 succeeds

  • merged

  • Sean McGivern mentioned in commit 3af7048f

    mentioned in commit 3af7048f

  • The qa-smoke job looked like it was stuck, so I cancelled it. Hopefully that wasn't a legitimate failure, although the previous pipeline (with fundamentally the same logic) passed.

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading