Add schema markup to breadcrumb
What does this MR do?
This MR adds schema markup for breadcrumbs. It adds it using ld+json because the breadcrumb generation logic is so intricate that it's really messy to introduce the microdata tags.
Refs #36844 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Separation of EE specific content
Related to #36844 (closed)
Merge request reports
Activity
changed milestone to %13.6
added SEOImprovement label
added typefeature label
added frontend label
1 Warning 
featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on throughput implementation.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Alexandru Croitor ( @acroitor) (UTC+2, 1 hour ahead of@fjsanpedro)Luke Duncalfe ( @.luke) (UTC+13, 12 hours ahead of@fjsanpedro)frontend Zack Cuddy ( @zcuddy) (UTC-6, 7 hours behind@fjsanpedro)Phil Hughes ( @iamphill) (UTC+0, 1 hour behind@fjsanpedro)test Quality for spec/features/*Anastasia McDonald ( @a_mcdonald) (UTC+13, 12 hours ahead of@fjsanpedro)Maintainer review is optional for test Quality for spec/features/*If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by 🤖 GitLab Bot 🤖-
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 1f043d22 and 2ffc4fda
Entrypoint / Name Size before Size after Diff Diff in percent average 3.11 MB 3.11 MB - 0.0 % mainChunk 1.88 MB 1.88 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
mentioned in issue #36844 (closed)
added 494 commits
-
f99111b5...2e3ed169 - 493 commits from branch
master - f48d59c1 - Add schema markup to breadcrumb
-
f99111b5...2e3ed169 - 493 commits from branch
marked the checklist item Changelog entry as completed
marked the checklist item Code review guidelines as completed
marked the checklist item Merge request performance guidelines as completed
marked the checklist item Style guides as completed
marked the checklist item Separation of EE specific content as completed
-
@vij can you review this MR?
assigned to @vij
- Resolved by Paul Slaughter
@fjsanpedro found some small typos and one non-blocking question for you, but otherwise this change looks good to me!
- Last reply by Anastasia McDonald
unassigned @vij
assigned to @vij
unassigned @vij
assigned to @zcuddy and @a_mcdonald
added workflowin review label and removed workflowin dev label
assigned to @pslaughter and unassigned @zcuddy
unassigned @a_mcdonald
Resolved by Paul Slaughterissue:
Disclaimer: I'm in no way an expert in this area.
I ran the resulting HTML of the project page through Google's Rich Results Test, and it looks like there's an issue with the URL field in our breadcrumb items.
I'm guessing it wants this to be a full URL with the host and everything. WDYT @fjsanpedro?
- Last reply by Paul Slaughter
- Resolved by Paul Slaughter
note (non-blocking): Looking at the standard, all of the examples have the structured data in the
<head>so I wasn't sure if it was safe to add this to the<body>. It turns out it is safe
- Last reply by Francisco Javier López
mentioned in issue #281378 (closed)
-
Thanks @fjsanpedro! I'm excited to see the results of this on prod (and for our public self-hosted customers)
LGTM!
Approving and MWPS'ing...
enabled an automatic merge when the pipeline for 95c4ff36 succeeds
mentioned in commit 98455e78
added workflowstaging label and removed workflowin review label
-
Thanks @pslaughter!
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue gitlab-com/www-gitlab-com#7376 (closed)
mentioned in merge request !47523 (merged)
added releasedcandidate label
mentioned in merge request !47854 (merged)
mentioned in issue gitlab-com/www-gitlab-com#7005 (closed)
added releasedpublished label and removed releasedcandidate label
