Skip to content

[EE] Fix a performance/memory issue in lib/api/services.rb

EE MR for https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17369

What does this MR do?

This fixes a performance/memory issue in lib/api/services.rb. This reduces the number of retained objects and memory, as explained in https://gitlab.com/gitlab-org/gitlab-ce/issues/43620.

Are there points in the code the reviewer needs to double check?

I don't think there are.

Why was this MR needed?

Because I stumbled upon this, and because performance matters!

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Closes gitlab-ce#43620.

Edited by Rémy Coutable

Merge request reports