Skip to content

Properly file_store default for pages deployments

Vladimir Shushlin requested to merge fix-pages-deployment-default-store into master

What does this MR do?

create!(file: somefile) actually assigns file before default_valud_for works. So Pages::DeploymentUploader gets the wrong default from the model and will always save file to disk storage regardless of object storage being enabled.

rails attributes api actually allows to set default properly

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports