Skip to content

Properly validate milestones array in releases API PUT method

What does this MR do?

Discovered during debugging of #277369 (closed). We already have this validation for POST method. But not for PUT.

Currently, the random data can cause problems like #277369 (comment 443924350). So we want to validate that this array is array of strings.

It won't fix the frontend bug, but at least API will return 4** and not 500 with a meaningful message.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vladimir Shushlin

Merge request reports

Loading