Skip to content
Snippets Groups Projects

Author and Assignees labels not working in VSA

All threads resolved!

What does this MR do?

In !42232 (merged) we removed some older instance level VSA code, in the process the setPaths action was updated to take a groupPath instead of a group object.

This MR:

  • Ensures we pass the groupPath to setPaths
  • Adds missing feature specs to test the arguments of the dispatched calls

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #276955 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits fa883dba and fecbb018

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.04 MB 3.07 MB +23.68 KB 0.8 %
    mainChunk 1.88 MB 1.88 MB - 0.0 %

    :fearful: Significant Growth: 1

    Expand
    Entrypoint / Name Size before Size after Diff Diff in percent
    pages.projects.ci.lints.show 111.36 KB 6.76 MB +6.65 MB 6113.3 %

    Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

    Please consider pinging someone from the FE Foundations (@dmishunov, @justin_ho, @mikegreiling or @nmezzopera) for review, if you are unsure about the size increase.

    Note: We do not have exact data for fa883dba. So we have used data from: 005e9e5d.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Ezekiel Kigbo marked the checklist item Changelog entry as completed

    marked the checklist item Changelog entry as completed

  • mentioned in issue #276955 (closed)

  • Ezekiel Kigbo assigned to @sming-gitlab and unassigned @ekigbo

    assigned to @sming-gitlab and unassigned @ekigbo

  • @ekigbo Thanks for the fix, I'm labelling this ~"Pick into 13.5".

  • added regression regression:13.5 + 1 deleted label

  • assigned to @mrincon

  • Samantha Ming approved this merge request

    approved this merge request

  • Ezekiel Kigbo added 126 commits

    added 126 commits

    Compare with previous version

  • Author Maintainer

    I realized i forgot to add the commit with the changelog, so ive just rebased master and included the changelog.

  • Miguel Rincon approved this merge request

    approved this merge request

  • Miguel Rincon resolved all threads

    resolved all threads

  • merged

  • Miguel Rincon mentioned in commit 7f95f25e

    mentioned in commit 7f95f25e

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • GitLab Release Tools Bot picked the changes into the branch 13-5-stable-ee-patch-4 with commit 2e118c58

    picked the changes into the branch 13-5-stable-ee-patch-4 with commit 2e118c58

  • Automatically picked into !47650 (merged), will merge into 13-5-stable-ee ready for 13.5.4-ee.

  • GitLab Release Tools Bot removed 1 deleted label

    removed 1 deleted label

  • Miguel Rincon mentioned in commit 2e118c58

    mentioned in commit 2e118c58

  • mentioned in merge request !47650 (merged)

  • Please register or sign in to reply
    Loading