Author and Assignees labels not working in VSA
What does this MR do?
In !42232 (merged) we removed some older instance level VSA code,
in the process the setPaths
action was updated to take a groupPath
instead of a group
object.
This MR:
- Ensures we pass the
groupPath
tosetPaths
- Adds missing feature specs to test the arguments of the dispatched calls
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #276955 (closed)
Merge request reports
Activity
changed milestone to %13.6
added devopsmanage frontend groupoptimize priority2 sectiondev typebug labels
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Thomas Randolph ( @thomasrandolph
) (UTC-7, 18 hours behind@ekigbo
)Miguel Rincon ( @mrincon
) (UTC+1, 10 hours behind@ekigbo
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @ekigbo
- Resolved by Miguel Rincon
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits fa883dba and fecbb018
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.04 MB 3.07 MB +23.68 KB 0.8 % mainChunk 1.88 MB 1.88 MB - 0.0 % Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.ci.lints.show 111.36 KB 6.76 MB +6.65 MB 6113.3 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Note: We do not have exact data for fa883dba. So we have used data from: 005e9e5d.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖marked the checklist item Changelog entry as completed
mentioned in issue #276955 (closed)
- Resolved by Miguel Rincon
Would you be free to review this bug fix @sming-gitlab ?
assigned to @sming-gitlab and unassigned @ekigbo
@ekigbo Thanks for the fix, I'm labelling this ~"Pick into 13.5".
added regression regression:13.5 + 1 deleted label
assigned to @mrincon
unassigned @sming-gitlab
added 126 commits
-
97e8ef73...fa883dba - 124 commits from branch
master
- 9be97cf0 - Update parameters passed to setPaths
- fecbb018 - Added changelog entry
-
97e8ef73...fa883dba - 124 commits from branch
mentioned in commit 7f95f25e
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
picked the changes into the branch
13-5-stable-ee-patch-4
with commit 2e118c58Automatically picked into !47650 (merged), will merge into
13-5-stable-ee
ready for13.5.4-ee
.mentioned in commit 2e118c58
mentioned in merge request !47650 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label