Skip to content

Remove unnecessary expand sha button

Paul Slaughter requested to merge 25145-remove-expand-sha-button-pipeline into master

What does this MR do?

This MR removes an unnecessary and buggy commit SHA expand button. See the issue for the reasons why this button is better removed than kept #25145 (closed).

This MR also cleans up some things:

  • Moves details_behavior.js to a module in commit_info so that it's not loaded on every page.
  • Removes unused styles.

Screenshots (strongly suggested)

Before (on master and .com) After (this MR)
Screen_Shot_2020-11-05_at_1.33.11_PM Screen_Shot_2020-11-05_at_1.22.22_PM

The expand button still works in the commit info box 🎉

Screen_Shot_2020-11-05_at_1.27.15_PM

Does this MR meet the acceptance criteria?

Conformity

References

Edited by Paul Slaughter

Merge request reports