Needless and buggy "click to expand" behavior for commit SHAs on pipeline pages

For example, on https://gitlab.com/gitlab-org/gitlab-ce/pipelines/36060926, we show the short SHA of the commit to which the pipeline belongs. For some reason, it's expandable to show the full SHA:

2018-11-09_15.36.39

There are a couple of issues with this:

  1. The "expand" link moves after being clicked
  2. After moving, clicking it does nothing -- it would presumably collapse back
  3. The "copy to clipboard" button should probably be before the "expand" link, since it's copying the SHA
  4. This is probably a useless feature. The copy to clipboard button already copies the full SHA regardless of expansion
  5. This is the only place we expand SHAs like this, AFAIK.
  6. The code for expanding is loaded on every page
  7. The js- selector is used for styling.
Edited Nov 04, 2020 by Robert Speicher
Assignee Loading
Time tracking Loading