Needless and buggy "click to expand" behavior for commit SHAs on pipeline pages
For example, on https://gitlab.com/gitlab-org/gitlab-ce/pipelines/36060926, we show the short SHA of the commit to which the pipeline belongs. For some reason, it's expandable to show the full SHA:
There are a couple of issues with this:
- The "expand" link moves after being clicked
- After moving, clicking it does nothing -- it would presumably collapse back
- The "copy to clipboard" button should probably be before the "expand" link, since it's copying the SHA
- This is probably a useless feature. The copy to clipboard button already copies the full SHA regardless of expansion
- This is the only place we expand SHAs like this, AFAIK.
- The code for expanding is loaded on every page
- The
js-selector is used for styling.
Edited by Robert Speicher
