Add feature flag to instance statistics page
What does this MR do?
Add feature flag limitations to Instance Statistics page.
Discussion in #235754 (comment 439345401)
Related issues
Author's checklist (required)
-
Follow the Documentation Guidelines and Style Guide. - If you have Developer permissions or higher:
-
Ensure that the product tier badge is added to doc's h1
. -
Apply the documentation label, plus: - The corresponding DevOps stage and group labels, if applicable.
-
development guidelines when changing docs under
doc/development/*
,CONTRIBUTING.md
, orREADME.md
. -
development guidelines and Documentation guidelines when changing docs under
development/documentation/*
. - development guidelines and Description templates (.gitlab/*) when creating/updating issue and MR description templates.
-
Assign the designated Technical Writer.
-
Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.
When applicable:
-
Update the permissions table. -
Link docs to and from the higher-level index page, plus other related docs where helpful. -
Add the product tier badge accordingly. -
Add GitLab's version history note(s). -
Add/update the feature flag section.
Review checklist
All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.
1. Primary Reviewer
-
Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.
2. Technical Writer
-
Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage. -
Ensure docs metadata are present and up-to-date. -
Ensure Technical Writing and documentation are added. -
Add the corresponding docs::
scoped label. -
If working on UI text, add the corresponding UI Text
scoped label. -
Add twdoing when starting work on the MR. -
Add twfinished if Technical Writing team work on the MR is complete but it remains open.
-
For more information about labels, see Technical Writing workflows - Labels.
For suggestions that you are confident don't need to be reviewed, change them locally and push a commit directly to save others from unneeded reviews. For example:
- Clear typos, like
this is a typpo
. - Minor issues, like single quotes instead of double quotes, Oxford commas, and periods.
For more information, see our documentation on Merging a merge request.
3. Maintainer
-
Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review. -
Ensure a release milestone is set. -
If there has not been a technical writer review, create an issue for one using the Doc Review template.
Merge request reports
Activity
changed milestone to %13.6
added Technical Writing docsfix documentation twdoing labels
assigned to @bbodenmiller
mentioned in issue #235754 (closed)
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
doc/user/admin_area/analytics/instance_statistics.md
The review does not need to block merging this merge request. See the:
- Technical Writers assignments for the appropriate technical writer for this review.
- Documentation workflows for information on when to assign a merge request for review.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Mike Jang
added devopsmanage groupoptimize labels
marked the checklist item Add twdoing when starting work on the MR. as completed
marked the checklist item Add the corresponding
docs::
scoped label. as completedmarked the checklist item Ensure Technical Writing and documentation are added. as completed
enabled an automatic merge when the pipeline for aba3198e succeeds
mentioned in commit 70c5ff50
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request gitlab-com/www-gitlab-com!67636 (merged)
8 8 9 9 > - [Introduced](https://gitlab.com/gitlab-org/gitlab/-/issues/235754) in GitLab 13.4. 10 10 11 CAUTION: **Warning:** 12 This feature might not be available to you. Check the **version history** note above for details. @mjang1 do you recall the reason for adding this warning? I reviewed this MR, but I can't recall why this was necessary and I'm tempted to submit an MR to remove it (as !46962 (merged) already removed the other changes below).
EDIT: Please ignore this, you already suggested removing the warning! MR for that here: !47454 (merged)
Edited by Dan Jensen
unassigned @bbodenmiller
mentioned in merge request !47454 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
added typemaintenance label
mentioned in merge request !82044 (merged)