Skip to content

WIP: Resolve "Move EE JavaScript tests to their own respective directory"

Rémy Coutable requested to merge 3871-move-ee-specific-javascript-tests-to-ee into master

What does this MR do?

This moves EE-specific JavaScript spec files from spec/javascripts to ee/spec/javascripts.

› git diff ce/master..HEAD --name-status --diff-filter=A -- spec/javascripts | cut -f2 | xargs -t -L1 -I % dirname % | xargs -t -L1 -I % mkdir -p ee/%
› git diff ce/master..HEAD --name-status --diff-filter=A -- spec/javascripts | cut -f2 | xargs -t -L1 -I % git mv % ee/%

Are there points in the code the reviewer needs to double check?

We should make sure that the karma job runs all the specs (CE and EE) and pass.

Why was this MR needed?

To separate EE-specific files from the CE ones.

Does this MR meet the acceptance criteria?

  • Review
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan
  • End-to-end tests pass (package-qa manual pipeline job)

What are the relevant issue numbers?

Closes #3871 (closed)

Edited by Rémy Coutable

Merge request reports