Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 35,731
    • Issues 35,731
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 1,268
    • Merge Requests 1,268
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !46214

Merged
Opened Oct 27, 2020 by Martin Wortschack@wortschi🔴Maintainer2 of 13 tasks completed2/13 tasks

Replace fa-warning icons with GitLab SVG warning-solid icon

  • Overview 9
  • Commits 1
  • Pipelines 21
  • Changes 13

What does this MR do?

This MR replaces the fa-warning icon with the warning-solid GitLab SVG.

Screenshots (strongly suggested)

Before After
admin_health_check_before admin_health_check_after
no_repo_before no_repo_after
admin_system_info_before admin_system_info_after
diff_warning_before diff_warning_after
ssl_limitations_warning_before ssl_limitations_warning_after
lets_encrypt_callout_before lets_encrypt_callout_after
project_mirror_failed_before project_mirror_failed_after
ci_runners_before ci_runners_after

Does this MR meet the acceptance criteria?

Conformity

  • Changelog entry
  • Documentation (if required)
  • Code review guidelines
  • Merge request performance guidelines
  • Style guides
  • Database guides
  • Separation of EE specific content

Availability and Testing

  • Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
  • Tested in all supported browsers
  • Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #225180 (closed)

Edited Oct 29, 2020 by Martin Wortschack
Assignee
Assign to
Reviewer
Request review from
13.6
Milestone
13.6 (Past due)
Assign milestone
Time tracking
Reference: gitlab-org/gitlab!46214
Source branch: 225180-replace-fa-warning-icons-with-gitlab-svg-warning-solid-icon