Replace fa-warning icons with GitLab SVG warning-solid icon
As part of the effort to replace FontAwesome icons with GitLab SVGs we need to use the warning-solid icon instead of the FontAwesome variants.
19 times: fa-exclamation-triangle
16 times: fa-warning
Also it will fix the fa-triangle reporting in the icons report as that is a false positive.
When you are done
- Add screenshots from before + after to make review easier and faster
- Get UX Review
- Get Frontend Maintainer review directly
- See https://leipert-projects.gitlab.io/is-gitlab-pretty-yet/icons/ for all Font Awesome icon instances
- See http://gitlab-org.gitlab.io/gitlab-svgs/ for all GitLab icons