Skip to content
Snippets Groups Projects

Update selected value stream after deletion or creation

Merged Ezekiel Kigbo requested to merge 263392-update-selected-value-stream-after-deletion into master
All threads resolved!

What does this MR do?

This MR Addresses #263392 (closed) and #267008 (closed)

  • Ensure we clear the selected value stream after deletion
  • Ensure we set the newly created value stream after creation

Testing

  1. Enable the value_stream_analytics_create_multiple_value_streams feature flag
  2. Navigate to group VSA http://localhost:3001/groups/gitlab-org/-/analytics/value_stream_analytics
  3. Create a custom value stream
  4. Your new stream should be selected
  5. From the value stream dropdown, delete a value stream
  6. A new value stream will be selected (or the default) if you only have 1 left

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #263392 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ezekiel Kigbo
  • Author Maintainer

    Hi @aturinske would you be free to review this MR?

  • Ezekiel Kigbo assigned to @aturinske and unassigned @ekigbo

    assigned to @aturinske and unassigned @ekigbo

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 2329d705 and 552c79f4

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.01 MB 3.01 MB - 0.0 %
    mainChunk 1.87 MB 1.87 MB - 0.0 %

    Note: We do not have exact data for 2329d705. So we have used data from: 3186e349.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • Alexander Turinske approved this merge request

    approved this merge request

  • Ezekiel Kigbo added 186 commits

    added 186 commits

    Compare with previous version

  • mentioned in issue #273107 (closed)

  • Author Maintainer

    Would you be free to maintainer review this MR @kushalpandya ?

  • Ezekiel Kigbo assigned to @kushalpandya and unassigned @ekigbo and @aturinske

    assigned to @kushalpandya and unassigned @ekigbo and @aturinske

  • Kushal Pandya resolved all threads

    resolved all threads

  • Kushal Pandya approved this merge request

    approved this merge request

  • merged

  • Kushal Pandya mentioned in commit 8ce3a303

    mentioned in commit 8ce3a303

  • mentioned in issue #267008 (closed)

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #263392 (closed)

  • Please register or sign in to reply
    Loading