Update selected value stream after deletion or creation
What does this MR do?
This MR Addresses #263392 (closed) and #267008 (closed)
- Ensure we clear the selected value stream after deletion
- Ensure we set the newly created value stream after creation
Testing
- Enable the
value_stream_analytics_create_multiple_value_streams
feature flag - Navigate to group VSA http://localhost:3001/groups/gitlab-org/-/analytics/value_stream_analytics
- Create a custom value stream
- Your new stream should be selected
- From the value stream dropdown, delete a value stream
- A new value stream will be selected (or the default) if you only have 1 left
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #263392 (closed)
Merge request reports
Activity
changed milestone to %13.6
added devopsmanage featureaddition frontend groupoptimize missed:13.5 sectiondev severity4 typebug typefeature workflowplanning breakdown + 1 deleted label
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Alexander Turinske ( @aturinske
) (UTC-6, 17 hours behind@ekigbo
)Olena HK. ( @ohoral
) (UTC+2, 9 hours behind@ekigbo
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @ekigbo
removed workflowplanning breakdown label
- Resolved by Kushal Pandya
- Resolved by Kushal Pandya
Hi @aturinske would you be free to review this MR?
assigned to @aturinske and unassigned @ekigbo
removed featureaddition label
added typemaintenance label
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2329d705 and 552c79f4
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.01 MB 3.01 MB - 0.0 % mainChunk 1.87 MB 1.87 MB - 0.0 %
Note: We do not have exact data for 2329d705. So we have used data from: 3186e349.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Ezekiel Kigbo
Looks good @ekigbo ! Approved! You just need a changelog!
question (non-blocking): I noticed that the
actions.js
file is becoming quite large (400+ lines), as well as it's associatedspec
file (900+ lines); could this feature benefit from this action file being broken up into feature-specific files (e.g. https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/assets/javascripts/ide/stores/modules/terminal/actions/index.js)?Edited by Alexander Turinske
assigned to @ekigbo
added 186 commits
-
b324540c...2329d705 - 183 commits from branch
master
- 47af2f7d - Clear the selected value stream after delete
- aa67c1ce - Set the selected value stream after create
- 552c79f4 - Added changelog entry
Toggle commit list-
b324540c...2329d705 - 183 commits from branch
mentioned in issue #273107 (closed)
Would you be free to maintainer review this MR @kushalpandya ?
assigned to @kushalpandya and unassigned @ekigbo and @aturinske
mentioned in commit 8ce3a303
mentioned in issue #267008 (closed)
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added Category:Value Stream Management label
mentioned in issue #263392 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-com/www-gitlab-com#12338 (closed)
removed typefeature label