Skip to content

Global Search - Project Filter

Zack Cuddy requested to merge 262060_02-project-filter-vue into master

What does this MR do?

Part 2 of 2 for #262060 (closed)
Fixes #281037 (closed)

This change replaces the deprecated jQuery Dropdown for the Project Filter on Global Search. It replaces the deprecated module with a Vue component using GlDropdown from GitLab UI.

To do so we simply moved the API calls and data tracking into the Vuex store and hooked it into a Vue component.

The Group filter has already been replaced as part of !44833 (merged)

Screenshots (strongly suggested)

before after
Empty Query Empty_Query_-_Before Empty_Query_-_After
With Group With_Group_-_Before With_Group_-_After
With Project With_Project_-_Before With_Project_-_After
No Group, Project Dropdown No_Group__Project_Dropdown_Open_-_Before No_Group__Open_Project_Dropdown_-_After
With Group, Project Dropdown With_Group__Open_Project_Dropdown_-_Before With_Group__Open_Project_Dropdown_-_After
Clear Button Clear_Button_-_Before Clear_Button_-_After
Loading State Loading_State_-_Before Loading_State_-_After

GIF

Kapture_2020-12-09_at_15.31.08

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports