Skip to content

Avoid opening 2 modals for enabling review app

What does this MR do?

The bug is described in #263402 (closed) (video available in Before column)

This MR corrects a misleading usage and naming of a component which caused the modal to be triggered twice:

  • moves the GlButton out of the component with GlModal
  • renames the component to clarify it contains a modal (only)
  • adds / updates tests to ensure enable-review-app-modal is never rendered more than once

Screenshots

before after
gitlab_issue2 Screen_Recording_2020-10-16_at_09.53.18

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #263402 (closed)

Edited by Angelo Gulina

Merge request reports