Skip to content

Alert integrations form cleanup

Olena Horal-Koretska requested to merge 262633-integrations-form-cleanup into master

What does this MR do?

Address all the items mentioned in this discussion !44318 (comment 423861572)

I've formatted them into TODO list

Broken_link

I think the docs have been moved recently. Could we update the link to the current one, which I believe is: http://10.0.1.6:3000/help/operations/incident_management/alert_notifications.md

  • Space between "Add new integrations" and the text below it:

Space

It looks like a tiny bit of extra space is appearing between the section heading and the text here. I think there might be 19px rather than 16?

  • HTTP Endpoint selection field:

Selection_field

I'm noticing three things with this field:

  1. It's missing the field header. With the header, it would look like this:

Field_title

  1. The "Learn more" help text is a very light grey currently. In looking at Figma, the help text should be grey-500 (#666666). Is the problem that the UI component still has the incorrect value attached to it or are we otherwise overriding it here?
  2. The upcoming integrations link also links to a closed epic 😬 I wonder if we should change this link to something that's actually useful? For example, we could change the text to be:

Learn more about our improvements for integrations

And the link could direct users to: &4390 (closed), which is our current planned work for improving this page?

  • It looks like the return value of the Prometheus error has changed format recently! This used to return user recoverable errors but appears to not be broken due to bogus destructing! This could be fixed via formatting the prometheus errors to the format expected by createUserErrorMessage or, extend the method createUserErrorMessage to handle the different format

Screenshots

Screen_Shot_2020-10-16_at_16.55.17## Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #262633 (closed)

Edited by Olena Horal-Koretska

Merge request reports