Alert integrations form cleanup
Address all the items mentioned in this discussion !44318 (comment 423861572)
I've formatted them into TODO list
-
The link to GitLab Documentation is currently broken - here's the link I mean:
I think the docs have been moved recently. Could we update the link to the current one, which I believe is: http://10.0.1.6:3000/help/operations/incident_management/alert_notifications.md
-
Space between "Add new integrations" and the text below it:
It looks like a tiny bit of extra space is appearing between the section heading and the text here. I think there might be 19px rather than 16?
-
HTTP Endpoint selection field:
I'm noticing three things with this field:
- It's missing the field header. With the header, it would look like this:
- The "Learn more" help text is a very light grey currently. In looking at Figma, the help text should be grey-500 (
#666666
). Is the problem that the UI component still has the incorrect value attached to it or are we otherwise overriding it here? - The upcoming integrations link also links to a closed epic
😬 I wonder if we should change this link to something that's actually useful? For example, we could change the text to be:
Learn more about our improvements for integrations
And the link could direct users to: &4390 (closed), which is our current planned work for improving this page?
-
It looks like the return value of the Prometheus error has changed format recently! This used to return user recoverable errors but appears to not be broken due to bogus destructing! This could be fixed via formatting the prometheus errors to the format expected by createUserErrorMessage
or, extend the methodcreateUserErrorMessage
to handle the different format
Edited by Olena Horal-Koretska