Skip to content

Fix label `x` button showing for unauthorized users

What does this MR do?

This MR hides the sidebar labels x for unauthorized users.

The x button on sidebar labels incorrectly shows even for unauthorized users. Security-wise, there is no issue since when unauthorized users click the x the backend authorization checks prevent the label from being removed. However, this MR fixes this UX inconsistency.

There is no changelog since this fixes a bug in the recently merged feature MR !42703 (merged)

Screenshots

before after
Screenshot_2020-10-14_at_4.55.50_pm Screenshot_2020-10-14_at_4.57.48_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #216881 (closed)

Edited by Coung Ngo

Merge request reports