Skip to content

Extract environments CSS from application bundle

What does this MR do?

This MR moves the environments style to its own bundle, out of the main application one following the steps described in the How to (which also suggest the utilisation of CSS variables instead of SCSS ones).

Screenshots

The screenshots provided present some cases that are mostly showing how removing the environments.scss files altogether seem not to affect the page so much. It hints to the fact the probably most of the environments.scss can be erased in a future iteration.

CE

Note: only difference with or without CSS is the banner

No CSS CSS
env_ce_no_css env_ce_css
Screenshot_2020-10-06_at_07.19.33 Screenshot_2020-10-06_at_07.27.18

EE

Note: looks the same with or without CSS

env_ee_001 env_ee_002 env_ee_003 env_ee_004 env_ee_005 env_ee_006

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports