Draft: Update traintainer for 3x standalone
What does this MR do?
Currently to achieve the 3x
for a trainee_maintainer
, we must also be listed as a reviewer
, else it will equate to a 2x
weight instead.
We could add ourselves as reviewer
as well, but then that doesn't seem to fit well for our team page where it lists our reviewer status:
I believe it would be better to have it display only one for backend
(perhaps a follow up should be done here for hungry as well if it shows up - since it now shows up there
Also those who are maintainers do not have reviewer listed as well, so this seems like merely a fix that needs to happen in danger...
Note: If agreed upon, will leave this in Draft
until a MR is merged to remove reviewer
from trainee_maintainer
s
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team