Skip to content

Draft: Update traintainer for 3x standalone

Doug Stull requested to merge adjust-danger-roullette-for-trainee into master

What does this MR do?

Currently to achieve the 3x for a trainee_maintainer, we must also be listed as a reviewer, else it will equate to a 2x weight instead.

We could add ourselves as reviewer as well, but then that doesn't seem to fit well for our team page where it lists our reviewer status:

Screen_Shot_2020-09-25_at_2.08.46_PM

I believe it would be better to have it display only one for backend(perhaps a follow up should be done here for hungry as well if it shows up - since it now shows up there 🎱 )

Also those who are maintainers do not have reviewer listed as well, so this seems like merely a fix that needs to happen in danger...

Screen_Shot_2020-09-24_at_11.19.12_AM

Note: If agreed upon, will leave this in Draft until a MR is merged to remove reviewer from trainee_maintainer s

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Doug Stull

Merge request reports