Update programming language colors and metadata
What does this MR do?
See the commit message
Conformity
Merge request reports
Activity
changed milestone to %13.5
added groupgitaly label
- Resolved by Adam Hegyi
added databasereview pending label
3 Warnings This merge request is quite big (more than 1460 lines changed), please consider splitting it into multiple merge requests. **New migrations added but db/structure.sql wasn’t updated.
**Usually, when adding new migrations, db/structure.sql should be
updated too (unless the migration isn’t changing the DB schema
and isn’t the most recent one).You’ve made some app changes, but didn’t add any tests.
That’s OK as long as you’re refactoring existing code,
but please consider adding any of the ~”tooling”, ~”tooling::pipelines”, ~”tooling::workflow”, ~”documentation”, ~”QA” labels.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer database Steve Abrams ( @sabrams
) (UTC-6, 8 hours behind@zj-gitlab
)Toon Claes ( @toon
) (UTC+2, same timezone as@zj-gitlab
)backend Valery Sizov ( @vsizov
) (UTC+2, same timezone as@zj-gitlab
)Shinya Maeda ( @shinya.maeda
) (UTC+7, 5 hours ahead of@zj-gitlab
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖- Resolved by Adam Hegyi
I've decided to hold off with this MR until Gitaly is bumped to the latest Linguist version, and I can update the vendored YAML to that version too.
added typemaintenance label
added typefeature label
added 1 commit
- 355960c8 - Update programming language colors and metadata
mentioned in issue #254682 (closed)
assigned to @mkaeppler
added 1 commit
- 19079080 - Update programming language colors and metadata
Setting label(s) devopscreate Category:Gitaly sectiondev based on groupgitaly.
added Category:Gitaly devopscreate sectiondev labels
- Resolved by Adam Hegyi
- Resolved by Adam Hegyi
assigned to @zj-gitlab and unassigned @mkaeppler
assigned to @ahegyi and unassigned @zj-gitlab
- Resolved by Adam Hegyi
Thanks @zj-gitlab,
The update runs fine on a replica. There are two points from Matthias that would worth considering:
- !43111 (comment 417933165)
- And using
ActiveRecord::Base.connection.quote
assigned to @zj-gitlab and unassigned @ahegyi
assigned to @ahegyi and unassigned @zj-gitlab
added 1 commit
- b78dc62a - Update programming language colors and metadata
added databaseapproved label and removed databasereview pending label
added 1323 commits
-
b78dc62a...c60be175 - 1322 commits from branch
master
- ee05bed0 - Update programming language colors and metadata
-
b78dc62a...c60be175 - 1322 commits from branch
enabled an automatic merge when the pipeline for 7194bcdf succeeds
mentioned in commit fad184cb
mentioned in issue gitaly#3157 (closed)
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.removed typefeature label