Skip to content
Snippets Groups Projects

Update programming language colors and metadata

Merged Zeger-Jan van de Weg requested to merge zj-update-lang-colors into master

Merge request reports

Merged results pipeline #196237892 passed

Merged results pipeline passed for 7194bcdf

Test coverage 70.17% from 3 jobs

Merged by Adam HegyiAdam Hegyi 4 years ago (Sep 30, 2020 8:10am UTC)

Loading

Pipeline #196265523 passed

Pipeline passed for fad184cb on master

Test coverage 56.42% from 3 jobs
5 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • 3 Warnings
    :warning: This merge request is quite big (more than 1460 lines changed), please consider splitting it into multiple merge requests.
    :warning: **New migrations added but db/structure.sql wasn’t updated.
    **

    Usually, when adding new migrations, db/structure.sql should be
    updated too (unless the migration isn’t changing the DB schema
    and isn’t the most recent one).

    :warning: You’ve made some app changes, but didn’t add any tests.
    That’s OK as long as you’re refactoring existing code,
    but please consider adding any of the ~”tooling”, ~”tooling::pipelines”, ~”tooling::workflow”, ~”documentation”, ~”QA” labels.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    database Steve Abrams (@sabrams) (UTC-6, 8 hours behind @zj-gitlab) Toon Claes (@toon) (UTC+2, same timezone as @zj-gitlab)
    backend Valery Sizov (@vsizov) (UTC+2, same timezone as @zj-gitlab) Shinya Maeda (@shinya.maeda) (UTC+7, 5 hours ahead of @zj-gitlab)

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • added 1 commit

    • 355960c8 - Update programming language colors and metadata

    Compare with previous version

  • mentioned in issue #254682 (closed)

  • added 1 commit

    • 19079080 - Update programming language colors and metadata

    Compare with previous version

  • assigned to @zj-gitlab and unassigned @mkaeppler

  • assigned to @ahegyi and unassigned @zj-gitlab

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading