Skip to content

Add support for Alerts to display the environment link

What does this MR do?

This MR is the first frontend iteration for #232492 (closed), it:

  • adds support to (conditionally) render the Environment name and URL for the Alert management details
  • covers the case where the URL is not available, therefore only displaying the name
  • filters out the environment url from the data provided for the alert tables, based on the proposal

Note that the order of the fields in the table is determined by the backend response, the 3rd screenshot is only reflecting a mock response.

Note 2: it is not yet fully clear whether this feature would go behind a feature flag, therefore the changelog is not yet provided.

Screenshots

Details Details w/out URL Table
Screenshot_2020-09-22_at_19.12.34 Screenshot_2020-09-22_at_19.14.01 Screenshot_2020-09-22_at_19.13.11

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Angelo Gulina

Merge request reports

Loading