Skip to content

Start using new DAST profiles routes

What does this MR do?

Now that the new DAST profiles routes have been created and are deployed, we can start using them in the app.

This MR does the switch between the old routes and the new ones by changing the paths that are being passed to the frontend apps, as well as updating the API responses to return the new routes.

This is an intermediary change before we effectively remove the old routes that are no longer needed. The new routes were added in !42600 (merged), and the old ones will be removed in !42123 (merged)

Updated paths

Old path New path
/on_demand_scans/profiles /security/configuration/dast_profiles
/on_demand_scans/profiles/dast_site_profiles/new /security/configuration/dast_profiles/dast_site_profiles/new
/on_demand_scans/profiles/dast_site_profiles/:id/edit /security/configuration/dast_profiles/dast_site_profiles/:id/edit
/on_demand_scans/profiles/dast_scanner_profiles/new /security/configuration/dast_profiles/dast_scanner_profiles/new
/on_demand_scans/profiles/dast_scanner_profiles/:id/edit /security/configuration/dast_profiles/dast_scanner_profiles/:id/edit
Description MR
Create new routes !42600 (merged)
👉 Start using new routes in the app !42859 (merged)
Remove old routes !42123 (merged)

Screenshots

Page Preview
Profiles management Screen_Shot_2020-09-15_at_1.04.39_PM
New scanner profile Screen_Shot_2020-09-15_at_1.04.53_PM
Edit scanner profile Screen_Shot_2020-09-15_at_1.04.46_PM
New site profile Screen_Shot_2020-09-15_at_1.05.06_PM
Edit site profile Screen_Shot_2020-09-15_at_1.04.59_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Paul Gascou-Vaillancourt

Merge request reports