Skip to content

Remove `projects/group_links/update.js.haml` in favor of vanilla JS

What does this MR do?

See #250655 (closed)

Part #21320, a larger initiative to remove all the *.js.haml templates.

This MR removes the legacy projects/group_links/update.js.haml template in favor of a vanilla JS solution. It affects changing the expiration date for linked groups in projects and groups.

Local testing

Groups

  1. Create a group
  2. Navigate to "Group" -> "Members".
  3. Click "Invite group" tab
  4. Invite a group
  5. In the "Groups" tab, change the "Expiration date". The text next to the avatar should say "Expires in ..."

Projects

  1. Create a project
  2. Navigate to "Project" -> "Members".
  3. Click "Invite group" tab
  4. Invite a group
  5. Change the "Expiration date" of that group. The text next to the avatar should say "Expires in ..."

Screenshots

No visual change

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports