Skip to content

Fix missing VSA request parameters

Ezekiel Kigbo requested to merge 250998-fix-missing-vsa-request-parameters into master

What does this MR do?

In !40826 (merged) we updated the request parameters for various VSA api requests to take an object instead of a list of parameters. This MR:

  • Updates the parameter name
  • Adds additional specs to ensure filters are applied

Steps to reproduce

  1. Navigate to VSA for a group ie. https://gitlab.com/groups/gitlab-org/-/analytics/value_stream_analytics
  2. Select a new start date, for example 2020-05-01
  3. The data in the stage table and charts should be updated
  4. The api requests will include the updated filter values

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Addresses #250998 (closed)

Edited by Mark Florian

Merge request reports