Skip to content

Wire-up EditDrawer with FrontMatterControls

Derek Knox requested to merge 241002-edit-drawer into master

What does this MR do?

Iterates (on MR1-4 outlined here) to:

  1. Wire up the previous pre-req MRs to bring this feature together
  2. Updates the UI so a GlDrawer encapsulates the front matter controls as designed.

Screenshots

Settings CTA

Screen_Shot_2020-09-09_at_9.52.14_AM

Settings drawer

Screen_Shot_2020-09-09_at_9.52.20_AM

Settings drawer overscroll

Screen_Shot_2020-09-09_at_11.57.14_AM

Settings CTA (mobile)

Screen_Shot_2020-09-09_at_12.00.57_PM

Settings drawer (mobile)

Screen_Shot_2020-09-09_at_12.01.00_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

closes #241003 (closed)

Edited by Derek Knox

Merge request reports