Skip to content

Remove height limit on environments table

Angelo Gulina requested to merge 235004-shortcut-deploy-to-is-shrinked into master

What does this MR do?

Relates to #235004 (closed). The MR introduces a CSS class on the table holder to make sure the height is not limited to the content of the table.

This will render the dropdown differently than what is currently.

Long list:

current my proposal
Screenshot_2020-09-07_at_13.26.42 Screenshot_2020-09-07_at_16.08.14

Short list:

current my proposal
Screenshot_2020-09-07_at_16.28.56 Screenshot_2020-09-07_at_16.29.16

Note: in mobile context a bug has been spotted (not related to this solution) which cannot be fixed without altering the desktop presentation. An Iusse has therefore been opened.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Justin Ho Tuan Duong

Merge request reports