Skip to content

Global Search - Bold Issue Search Term

Zack Cuddy requested to merge 244427-bold-search-term-issues into master

What does this MR do?

Closes #244427 (closed)

This adds search term bolding to the Issues Search Result Page. Note the screenshots searching for the term design

Important Notes for Scalability

  • Currently the search results are handled explicitly by their own file, so this change will make the rest of the search results look significantly different.
  • These results are still in HAML, we may look to approaching the search results more generically from a higher level so we don't need to manage each results view separately.
  • Refactoring the results into Vue would be a good next step as we can tackle both of the above points while also moving the views into our frontend framework.

Screenshots

Before

before

After

Simple Search Advanced Search
Basic Basic_-_Basic_Search Not Supported
Elastic Elastic_-_Basic_Search Elastic_-_Advanced_Search

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #244427 (closed) cc/ @gitlab-org/search-team

Edited by Terri Chu

Merge request reports