Skip to content

Backport expire_at from carrierwave 2.1.* to patch

Vladimir Shushlin requested to merge carrierwave_expire_at into master

What does this MR do?

We want to use custom expire_at for pages object storage links to make them valid for longer(24 hours). These links won't be exposed to end users, and will be used by pages only

See !40361 (comment 401848949)

Since this method is patched in gitlab codebase, we need to also backport https://github.com/carrierwaveuploader/carrierwave/commit/64aab24f57e4e1f7489e9faa37d6782818c164cc

Part of #238986 (closed)

This can be safely removed once we update carrierwave to > 2.1.0

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kamil Trzciński

Merge request reports