Move issues to the end on creation in the new-issue-worker
What does this MR do?
Related to #238416 (closed)
We have seen query timeouts during movement and rebalancing operations as part of Issue#move_to_end
. Due to the nature of movements, we cannot offer constant time guarantees, so the best thing is to move this operation into the NewIssueWorker
.
This calls Issue.move_nulls_to_end
on recently created unpositioned issues, which will preserve creation order with more fidelity in the presence of out-of-order execution of multiple workers.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis