Skip to content

Improve UI in security reports

Filipa Lacerda requested to merge 4310-security-reports into master

What does this MR do?

  • Make inline buttons right aligned/floated
  • Introduce actual colored icons for the - and + and have less screaming red text

Screenshots (if relevant)

Screen_Shot_2018-01-26_at_12.20.52

Screen_Shot_2018-01-26_at_12.22.04

Screen_Shot_2018-01-26_at_12.27.20

How to test locally

@dimitrieh I don't have these reports set up locally, in order to test this I hacked around a little: in this file ee/app/assets/javascripts/vue_merge_request_widget/mr_widget_options.js, do the following

  1. line 44 change the content to return true:
shouldRenderDockerReport() {
  return true;
},
  1. line 338 change the content with:
this.mr.setDockerReport({
      unapproved: [
        'CVE-2017-12944',
        'CVE-2017-16232',
      ],
      vulnerabilities: [
        {
          vulnerability: 'CVE-2017-12944',
          namespace: 'debian:8',
          severity: 'Medium',
        },
        {
          vulnerability: 'CVE-2017-16232',
          namespace: 'debian:8',
          severity: 'Negligible',
        },
        {
          vulnerability: 'CVE-2014-8130',
          namespace: 'debian:8',
          severity: 'Negligible',
        },
      ],
    });
  1. Just to check the success icon, on line 408 add :resolved-issues="mr.dockerReport.approved"

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

#4310 (closed)

Edited by Dimitrie Hoekstra

Merge request reports